opsi-deploy-preloginloader bug

[wardenik]

opsi:/opt/pcbin/install/preloginloader# ./opsi-deploy-preloginloader pc123
Password:
--------------------------------------------
pc123
--------------------------------------------
[warning] No ping response received from 192.168.100.123
[error] ERROR: Failed to install preloginloader: Command './winexe -U Administrator321Password //pc123 "c:\opsi_sW9wwFizmQ\files\opsi\utils\winst32.exe /batch c:\opsi_sW9wwFizmQ\files\opsi\preloginloader.ins c:\tmp\preloginloader.log /PARAMETER REMOTEDEPLOY"' failed (6): =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
INTERNAL ERROR: Signal 11 in pid 17038 (4.0.0tp3-SVN-build-15926)
Please read the file BUGS.txt in the distribution
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
PANIC: internal error
BACKTRACE: 35 stack frames:
#0 [0x82928ff]
#1 [0x8292bf5]
#2 [0x8292d43]
#3 [0x8292d77]
#4 [0xb7f43400]
#5 [0x82b3145]
#6 [0x82b279b]
#7 [0x828fbe9]
#8 [0x828fd3c]
#9 [0x828dd51]
#10 [0x828e20e]
#11 [0x828e778]
#12 [0x8083700]
#13 [0x8088cd9]
#14 [0x8079ab8]
#15 [0x807a5a5]
#16 [0x807a7b2]
#17 [0x807a91b]
#18 [0x821176e]
#19 [0x807fdf8]
#20 [0x821176e]
#21 [0x820e33e]
#22 [0x821176e]
#23 [0x820e8d4]
#24 [0x8219b01]
#25 [0x821a642]
#26 [0x82193aa]
#27 [0x8211500]
#28 [0x807aa80]
#29 [0x807ab21]
#30 [0x8082b53]
#31 [0x80724bf]
#32 [0x8048f23]
#33 [0x82b2003]
#34 [0x8048141]

[wolfbardo]

opsi:/opt/pcbin/install/preloginloader# ./opsi-deploy-preloginloader pc123
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
INTERNAL ERROR: Signal 11 in pid 17038 (4.0.0tp3-SVN-build-15926)
Please read the file BUGS.txt in the distribution
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

check your winexe-Version.

winexe is not a opsi programm but one of the samba project (see also)

viewtopic.php?f=8&t=367

regards
Bardo Wolf

[wardenik]

hi,

coming back on this one with more bugs.

opsi:/opt/pcbin/install/preloginloader# /opt/pcbin/install/preloginloader/winexe -V
Version 4.0.0tp3-SVN-build-15926

anyway you can see that in the stacktrace. moreover, wmi-client is not in testing but in unstable in Debian.
So, i have downloaded this file from unstable and replaced it manually but it should be in opsi package anyway (the correct version).

Now it almost works, but:
opsi:/opt/pcbin/install/preloginloader# ./opsi-deploy-preloginloader -r opsiclient
Password:
--------------------------------------------
opsiclient.domain
--------------------------------------------
[error] ->>> 'C:\Program' is not recognized as an internal or external command,
[error] ->>> operable program or batch file.
[error] Failed to reboot computer: Command './winexe -U Administrator%1234 //opsiclient "cmd.exe /C %PROGRAMFILES%\opsi.org\preloginloader\utils\shutdown.exe /L /R /T:20 \"opsi-preloginloader installed - reboot\" /Y /C"' failed (256): 'C:\Program' is not recognized as an internal or external command,
operable program or batch file.

I tested a lot of versions of the ", ', `. and none of them worked.
The only thing that worked was to write Progra~1 instead of longname...
any suggestions on this bug?

[wardenik]

Und noch eine:

when the Administrator password begins with a capital N, then the opsi-deploy-preloginloader fails:
[error] ERROR: Failed to install preloginloader: Command './winexe -U Administrator321restofpassword
(...)
failed (256): ERROR: Failed to open connection - NT_STATUS_LOGON_FAILURE

because %N is expanded to 321 (!?!)

[j.schneider]

Hi,

thanks for the bug report.
Could you please try the attached version?

[wardenik]

Hi,

Nope, check the attached log.

[wardenik]

One fix for sure:
84c84
< execute( '%s -U %s/%s //%s "%s"' % ('./winexe', host, username.replace('\\', '\\\\') + '%' + password, host, cmd) )
---
> execute( '%s -U %s //%s "%s"' % ('./winexe', username.replace('\\', '\\\\') + '%' + password, host, cmd) )

but the second problem is still unsolved (with restart command not working because of long "Program files")

[j.schneider]

Thank you for the fix!

[j.schneider]

Hi wardenik,

could you please test this:

Code: Alles auswählen

cmd = 'cmd.exe /C \\"\\"%PROGRAMFILES%\\\\opsi.org\\\\preloginloader\\\\utils\\\\shutdown.exe\\" /L /R /T:20 \\"opsi-preloginloader installed - reboot\\" /Y /C\\"'

[wardenik]

works!
many thanks
I will modify shutdown the same way of course.